Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSR-0 vendor namespace #47

Merged
merged 1 commit into from
Jun 12, 2014
Merged

PSR-0 vendor namespace #47

merged 1 commit into from
Jun 12, 2014

Conversation

goetas
Copy link
Member

@goetas goetas commented Jun 11, 2014

Implements #46

@goetas goetas mentioned this pull request Jun 11, 2014
@goetas goetas added this to the 2.0 milestone Jun 11, 2014
@goetas goetas mentioned this pull request Jun 11, 2014
@goetas
Copy link
Member Author

goetas commented Jun 11, 2014

Just one last thing before merging it...
The new FQCN of HTML5 main class is Masterminds\HTML5, does it make sense to have Masterminds\HTML5\HTML5 or Masterminds\HTML5\DOMHTML5 as new FQCN?

Usually the class name is composed by vendor\project\class ( example: Doctrine\ORM\EntityManager).

So we should have:
vendor: Masterminds
project: HTML5 (or we can rename it?)
class: HTML5 (or we can rename it?)

I already know that this is not a very important thing, but i prefer to hear an opinion by @technosophos or @mattfarina

@technosophos
Copy link
Member

I guess we could use the GitHub project name and do

Masterminds
HTML5-PHP
HTML5

On Wed, Jun 11, 2014 at 3:08 PM, Asmir Mustafic notifications@github.com
wrote:

Just one last thing before merging it...
The new FQCN of HTML5 is Masterminds\HTML5, does it make sense to have
Masterminds\HTML5\HTML5 or Masterminds\HTML5\DOMHTML5 as new FQCN?

Usually the class name is composed by vendor\project\class ( example:
Doctrine\ORM\EntityManager).

So we should have:
vendor: Masterminds
project: HTML5 (or we can rename it?)
class: HTML5 (or we can rename it?)

I already know that this is not a very important thing, but i prefer to
hear an opinion by @technosophos https://github.com/technosophos or
@mattfarina https://github.com/mattfarina


Reply to this email directly or view it on GitHub
#47 (comment).

http://technosophos.com
http://querypath.org

@goetas goetas merged commit d6940c3 into Masterminds:master Jun 12, 2014
@goetas goetas deleted the masterminds-namespace branch June 16, 2014 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants