Compatible with facebook HHVM 3.2 #52
Conversation
goetas
changed the title
|
@mattfarina @technosophos What you think about this? |
| @@ -7,6 +7,7 @@ | |||
| </testsuites> | |||
| <filter> | |||
| <blacklist> | |||
| <file>systemlib.phpreflection_hni</file> | |||
There was a problem hiding this comment.
I'm not all that familiar with HHVM. What is systemlib.phpreflection_hni and why is it blacklisted but not part of the repo?
There was a problem hiding this comment.
it is a phpunit/codecoverage limitation
I have commented it here https://github.com/goetas/html5-php/commit/f902b05cc252721e5440f3437d0c5de3e0a8d789#comments
It could blacklisted by default, but it is a @sebastianbergmann issue
There was a problem hiding this comment.
Yeah, we can (and should) fix it. Can you cook up a small example and submit an issue please?
There was a problem hiding this comment.
@sebastianbergmann @ptarjan I've opened an issue here: facebook/hhvm#2992
|
HHVM support will be a nice thing. I'm glad to see you're working on it. |
goetas
changed the title
|
Squashed all commits into one. |
|
It looks good to me. This patch has all the new error reporting calls, so I'm happy to get that in. |
This patch to make HTML5 compatible with HHVM contains also workaround to avoid this facebook/hhvm#2962