HTML parsing options #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flexible HTML DOM creation. New Options: * disableHtmlNsInDom = Allows the use of createElement instead of createElementNS for HTML elements. * targetDocument = allows an existing DOMDocument (or subclass thereof) to be passsed to the DOMTreeBuilder instead of creating a new one.
goetas
force-pushed
the
feature/html-parsing-options
branch
from
8d51ad4
to
a5f8b8c
Compare
goetas
force-pushed
the
feature/html-parsing-options
branch
from
effaccd
to
a50e919
Compare
|
@mattfarina @technosophos On monday i'm planning to merge this and release the 2.1.0 version. Any thoughts? //cc @jslegers |
| * `disable_html_ns` (boolean): Prevents the parser from automatically | ||
| assigning the HTML5 namespace to the DOM document. This is for | ||
| non-namespace aware DOM tools. | ||
| * `target_doc` (\DOMDocument): A DOM document that will be used as the |
There was a problem hiding this comment.
I just noticed this: the code expects 'target_document' but the docs say 'target_doc', which shall we change to make it consistent?
|
@cognifloyd fixed on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #69
This change has to be integrated