Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constraint Parser Error #34

Closed
vdice opened this issue Dec 2, 2016 · 3 comments
Closed

constraint Parser Error #34

vdice opened this issue Dec 2, 2016 · 3 comments

Comments

@vdice
Copy link

vdice commented Dec 2, 2016

I've encountered the following issue by way of specifying a 'pre-release' Helm chart version dependency.

When specifying a chart version of, say, v2.3.5-sha.20d586f, it is happily parsed/constrained by this package and Helm is happy as well.

However, when adding a timestamp, resulting in a chart version of v2.3.5-20161202202307-sha.e8fc5e5, this package returns a constraint Parser Error from the following logic.

In local testing, semver.NewConstraint() seems to allow up to 10 digits for the timestamp without throwing this particular error -- is there a semver rule that is being broken here in using >10 digits (14 to be precise)? Or, might this be an addressable parsing issue in this package?

@mattfarina
Copy link
Member

There is no rule about digit length. In this case the pre-release would be 20161202202307-sha.e8fc5e5. I'll take a look at it on Monday.

@mattfarina
Copy link
Member

A PR was started in #35

@mattfarina
Copy link
Member

@vdice Can you take a look at #36? I think this will fix it.

mattfarina added a commit that referenced this issue Dec 13, 2016
Fixed #34: Simple range syntax requires a space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants