Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a bcrypt function #242

Merged
merged 1 commit into from Dec 2, 2020
Merged

Add a bcrypt function #242

merged 1 commit into from Dec 2, 2020

Conversation

robbiet480
Copy link
Contributor

Continues work at #225 by adding a bcrypt function. htpasswd has been modified to use the bcrypt function.

I could've gotten away with using the htpasswd function in my app and setting username to empty string but then I'd also have to trim off the leading :. This seems cleaner for everyone.

cc @rustycl0ck

@rustycl0ck
Copy link
Contributor

lgtm

@lukasmrtvy
Copy link

merge ?

@rustycl0ck
Copy link
Contributor

Sorry @lukasmrtvy , I'm not one of the maintainers of this project. I just shared my lgtm opinion 🙂 (because it is based on #225 which was created by me)

Maybe @technosophos or one of the other maintainers can take a look at it and help move this forward.

@mattfarina mattfarina merged commit ed89b5b into Masterminds:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants