Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple-value uuid.NewV4() #74

Closed
wants to merge 1 commit into from
Closed

Conversation

sfrek
Copy link

@sfrek sfrek commented Jan 17, 2018

Error found:

# github.com/Masterminds/sprig
../../Masterminds/sprig/crypto.go:35: multiple-value uuid.NewV4() in single-value context

@chris-scentregroup
Copy link

chris-scentregroup commented Jan 19, 2018

@sfrek test failed. Does work for me if I apply the change on the last release.

@nemosupremo
Copy link

#73 also fixes this issue, which has been open for 14 days.

@sfrek
Copy link
Author

sfrek commented Jan 24, 2018

Hi @chris-scentregroup , sorry by my delay in answer.

I'm going to close that pull request, because I've tested it deeper and I've discovered the problem was satori/go.uuid version, because I was using your sprig library with the satori/go.uuid's master branch, no with the last release.

Thanks for all.

@sfrek sfrek closed this Jan 24, 2018
@chris-scentregroup
Copy link

Well the idea of go get is that it does use the default branch which is usually master. A stable head should be maintained, so this still needs fixing.

@jhoelzel
Copy link

jhoelzel commented Mar 2, 2018

Another quick fix for this on Windows is to just open up the src of github.com/satori/go.uuid and change the current branch over the integrated Git management to v1.2. After that everything builds as usual =)

you may wanna put a notice into the readme until this is fully resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants