logging adapted to work with logstash setup (whiner-slf4j)

project.clj

@@ -1,4 +1,4 @@
-(def slf4j-version "1.7.12")
+(def slf4j-version "1.7.21")
 (def cider-nrepl-version "0.9.1")
 
 (defproject witan.app "0.1.18-SNAPSHOT"
@@ -24,11 +24,10 @@
                  [kixi/schema-contrib "0.2.0"]
                  [kixi/compojure-api "0.24.0"]
                  [org.clojure/tools.logging      "0.3.1"]
-                 [ch.qos.logback/logback-classic "1.1.3"]
+                 [ch.qos.logback/logback-classic "1.1.7"]
                  [org.slf4j/jul-to-slf4j         ~slf4j-version]
                  [org.slf4j/jcl-over-slf4j       ~slf4j-version]
                  [org.slf4j/log4j-over-slf4j     ~slf4j-version]
-                 [net.logstash.logback/logstash-logback-encoder "4.6"]
                  [javax.mail/mail                "1.4.7"]
                  [overtone/at-at "1.2.0"]
                  [com.amazonaws/aws-java-sdk "1.10.27"]

resources/logback.xml

@@ -4,29 +4,20 @@
   <!-- Console output -->
   <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
     <!-- encoder defaults to ch.qos.logback.classic.encoder.PatternLayoutEncoder -->
-    <encoder class="net.logstash.logback.encoder.LogstashEncoder">
-      <customFields>{"appName": "witan-app"}</customFields>
+    <encoder>
+      <pattern>%date{ISO8601} %-5level %logger{36} - %msg%n</pattern>
     </encoder>
+
     <!-- Only log level INFO and above -->
     <filter class="ch.qos.logback.classic.filter.ThresholdFilter">
       <level>INFO</level>
     </filter>
   </appender>
 
-  <!-- removed mail appender for now, see  https://github.com/MastodonC/an-media.loader/blob/master/resources/logback.xml for example -->
-
-  <appender name="SYSLOG" class="ch.qos.logback.classic.net.SyslogAppender">
-    <syslogHost>localhost</syslogHost>
-    <facility>LOCAL0</facility>
-    <suffixPattern>%logger{35} %X{pipejine.q} - %message%n</suffixPattern>
-  </appender>
-
   <!-- Enable FILE and STDOUT appenders for all log messages.
        By default, only log at level INFO and above. -->
   <root level="DEBUG">
     <appender-ref ref="STDOUT" />
-    <!-- appender-ref ref="EMAIL" / -->
-    <appender-ref ref="SYSLOG" />
   </root>
 
   <logger name="com" level="INFO" />

src/witan/app/handler.clj

@@ -22,6 +22,7 @@
             [witan.app.schema :as w]
             [compojure.api.sweet :as sweet]
             [compojure.api.upload :as upload]
+            [compojure.api.exception :as exception]
             [ring.util.http-response :refer :all]
             [clj-time.core :as t]
             [overtone.at-at :as at]))
@@ -102,7 +103,17 @@
     (println "RESOURCE: " result)
     result))
 
+(defn logging-handler [^Exception e data request]
+  (log/error e)
+  (internal-server-error {:message (.getMessage e)}))
+
+(defn schema-logging-handler [^Exception e data request]
+  (log/error e)
+  (exception/schema-error-handler e data request))
+
 (sweet/defapi app'
+  {:exceptions {:handlers {:compojure.api.exception/default logging-handler
+                           :compojure.api.exception/response-validation schema-logging-handler}}}
   (sweet/swagger-ui)
   (sweet/swagger-docs
    {:info {:title "Witan API"
@@ -234,9 +245,10 @@
       response)))
 
 ;; the Ring app definition including the authentication backend
-(def app (-> app'
-             (wrap-authorization auth-backend)
-             (wrap-authentication auth-backend)
-             (wrap-cors :access-control-allow-origin [#".*"]
-                        :access-control-allow-methods [:get :put :post :delete])
-             (wrap-logger)))
+(def app
+  (-> app'
+      (wrap-authorization auth-backend)
+      (wrap-authentication auth-backend)
+      (wrap-cors :access-control-allow-origin [#".*"]
+                 :access-control-allow-methods [:get :put :post :delete])
+      (wrap-logger)))

src/witan/bootstrap.clj

@@ -8,12 +8,6 @@
             [clojure.tools.nrepl.server :as nrepl-server]
             [com.stuartsierra.component :as component]))
 
-;; See http://stuartsierra.com/2015/05/27/clojure-uncaught-exceptions
-(defn install-default-exception-handler []
-  (Thread/setDefaultUncaughtExceptionHandler
-   (reify Thread$UncaughtExceptionHandler
-     (uncaughtException [_ thread ex]
-       (log/error ex "Uncaught exception on " (.getName thread))))))
 
 (defrecord ReplServer [config]
   component/Lifecycle
@@ -50,6 +44,10 @@
       (println banner)
       (System/exit 0))
 
-    (install-default-exception-handler)
+    ;; See http://stuartsierra.com/2015/05/27/clojure-uncaught-exceptions
+    (Thread/setDefaultUncaughtExceptionHandler
+     (reify Thread$UncaughtExceptionHandler
+       (uncaughtException [_ thread ex]
+         (log/error ex "Uncaught exception on" (.getName thread)))))
 
     (alter-var-root #'witan.application/system (fn [_] (component/start (build-application opts))))))

src/witan/system.clj

@@ -7,6 +7,7 @@
             [witan.app.config           :as conf]
             [witan.app.components.kafka :as kafka]))
 
+
 (defrecord JettyServer [handler port]
   component/Lifecycle
   (start [this]