Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create manual theme switch button #17

Merged
merged 7 commits into from
Nov 9, 2023

Conversation

Matdweb
Copy link
Owner

@Matdweb Matdweb commented Nov 9, 2023

About the Pull Request

This pull request introduces the implementation of a user interface button, enabling manual toggling between light and dark modes on the page. The primary aim is to enhance user experience and streamline the development process by allowing users to customize their viewing experience and providing developers with an efficient means of UI testing.

Details

Objective

The main objective of this pull request is to successfully implement the user interface button for manual theme switching, aligning with the ticket's requirements.

Changes Made

  1. Next Themes Packages Installation:

    • Installed the required Next Themes packages to enable theme switching.
  2. ThemeProvider Integration:

    • Wrapped the app in the ThemeProvider, ensuring it's placed inside the body HTML tag for effective theme application.
  3. Mode Toggle Button Creation:

    • Created a button to allow users to switch between light, dark, or system themes.

Dependencies

Impact

The introduction of the manual theme switch button significantly enhances user experience, providing users with customization options. Simultaneously, developers benefit from improved UI testing capabilities and streamlined theme validation.

Screenshots

Video Demonstration
darkLigthModeButton

Note: The ThemeProvider was not placed in the Providers.tsx component as it wraps the app from the HTML, and the ThemeProvider only needs to wrap the body's children for proper functionality.

@Matdweb Matdweb self-assigned this Nov 9, 2023
@Matdweb Matdweb linked an issue Nov 9, 2023 that may be closed by this pull request
Copy link

vercel bot commented Nov 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
twitter-clone ✅ Ready (Inspect) Visit Preview Nov 9, 2023 2:48am

@Matdweb Matdweb merged commit 593c54d into main Nov 9, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: create manual theme switch button
1 participant