Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: create global styles #2

Merged
merged 13 commits into from
Oct 20, 2023
Merged

style: create global styles #2

merged 13 commits into from
Oct 20, 2023

Conversation

Matdweb
Copy link
Owner

@Matdweb Matdweb commented Oct 19, 2023

About the Pull Request

This pull request aims to enhance the project by creating global CSS styles and Tailwind CSS properties. It involves the installation of essential packages, integration of new fonts, creation of consistent CSS classes for styling, and configuration changes in alignment with the provided design solutions in the Figma documents.

You can check them in the Figma documents for the desktop version and the responsive version.

Details

Objective

  • Create global CSS and Tailwind properties to improve development efficiency and maintain consistency within the project.
  • Utilize best practices and align with the design solutions specified in the Figma document.

Changes Made

  1. Integration of New Fonts

    • Added Segoe UI and Roboto fonts to the project.
    • Created Tailwind CSS variables to facilitate their use throughout the project.
  2. Creation of CSS Classes

    • Designed CSS classes for styling, following the Figma design solutions:
      • .font-big-title: For large titles.
      • .font-primary-title-roboto: For primary titles using the Roboto font.
      • .font-primary-title-bold: For bold primary titles.
      • .font-primary-text: For primary text elements.
      • .font-secondary-text: For secondary text elements.
      • .font-gray-text: For gray-colored text.
  3. Responsive Solutions

    • Implemented responsive solutions based on the provided design solutions in the Figma document for a consistent interface.

Dependencies

Configuration Changes

  • Adjusted the Tailwind CSS configuration to:
    • Define primary colors.
    • Assign font families correctly.
    • Manually handle dark mode, following the Tailwind CSS documentation.

User Interface (UI) Changes

  • The layout demonstrates the application of CSS classes and styles, providing a basic visual representation of their effects.

Testing

  • The layout mentioned earlier is used for testing styles, configurations, and classes to ensure correct implementation. View the page rendering here.

Known Issues

Impact

User Impact

  • This implementation significantly enhances the user experience by providing correct text sizes and fonts for effective information sharing.
  • It also improves button styles with clear signifiers.

Performance Impact

  • The use of next/font, even with local fonts like Segoe UI, significantly improves performance.

@Matdweb Matdweb self-assigned this Oct 19, 2023
@Matdweb Matdweb linked an issue Oct 19, 2023 that may be closed by this pull request
@Matdweb
Copy link
Owner Author

Matdweb commented Oct 20, 2023

Hi,

It seems that react-icons libraryis missing but it will be handled in a separate ticket. To keep the development process smooth, I suggest merging this pull request while we create a new ticket specifically for addressing the 'react-icons' integration. Your prompt action on this matter is greatly appreciated.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creare global styles
1 participant