Fix #35 - Support nonescaping closure parameters #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
==========================================
+ Coverage 96.53% 96.68% +0.14%
==========================================
Files 16 17 +1
Lines 664 693 +29
==========================================
+ Hits 641 670 +29
Misses 23 23 ☔ View full report in Codecov by Sentry. |
Matejkob
reviewed
Dec 29, 2023
There was a problem hiding this comment.
Thank you very much for your contribution! I apologize for the delay in getting this review to you. I plan to allocate more time to this project in the future.
I've left a few inline comments, but they are minor. Overall, your changes look really good to me! Thanks once again for your contribution!
Sources/SpyableMacro/Extensions/FunctionParameters+Extensions.swift
Outdated
Show resolved
Hide resolved
Sources/SpyableMacro/Extensions/FunctionParameters+Extensions.swift
Outdated
Show resolved
Hide resolved
Tests/SpyableMacroTests/Extensions/UT_FunctionParameterListSyntax+Extensions.swift
Outdated
Show resolved
Hide resolved
# Conflicts: # Sources/SpyableMacro/Factories/ClosureFactory.swift # Tests/SpyableMacroTests/Factories/UT_ClosureFactory.swift
|
My last changes resulted in new conflicts in this PR. Here is PR to your fork that solves those conflicts: dafurman#1 |
Resolves conflicts
…swift Co-authored-by: Mateusz Bąk <bakmatthew@icloud.com>
…swift Co-authored-by: Mateusz Bąk <bakmatthew@icloud.com>
…tax+Extensions.swift Co-authored-by: Mateusz Bąk <bakmatthew@icloud.com>
Matejkob
approved these changes
Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #35 for a description of the issue that this PR solves.
I also added support for parameters using autoclosure, as I noticed that attempting to use it would lead to a compilation issue:
