Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support For .NET Core 3.0 #1134

Closed
Keboo opened this issue Dec 4, 2018 · 9 comments
Closed

Add Support For .NET Core 3.0 #1134

Keboo opened this issue Dec 4, 2018 · 9 comments
Assignees
Milestone

Comments

@Keboo
Copy link
Member

Keboo commented Dec 4, 2018

WPF will support .NET Core 3.0.

This is a parent issue for any compatibility issues that are raised.
https://blogs.msdn.microsoft.com/dotnet/2018/12/04/announcing-net-core-3-preview-1-and-open-sourcing-windows-desktop-frameworks/

@Keboo Keboo self-assigned this Dec 4, 2018
@ButchersBoy ButchersBoy assigned ButchersBoy and unassigned Keboo May 10, 2019
@enizvk
Copy link

enizvk commented Jun 4, 2019

Any news or plans on this?

@steven62f
Copy link

Same question. Any news about support for .NET Core 3.0 ?

@jespersh
Copy link
Contributor

Hi,

The only issue I currently have with porting this to netcoreapp3.0 is ShowMeTheXaml.
My last commit here https://github.com/jespersh/MaterialDesignInXamlToolkit removed all the ShowMeTheXaml (last elegantly, so all controls in a grid is a mess currently) for a quick revert once SMTX works.
So while it is entirely possible... The change most endangering is that this might not make .Net framework work (unless maybe 4.7.2)

image

image

@Keboo
Copy link
Member Author

Keboo commented Jul 16, 2019

@jespersh that is great. If you want to get a PR open we can start looking at getting it merged. I have a preview NuGet for ShowMeTheXaml that is out that adds .Net Core 3.0 support as well.

@enizvk
Copy link

enizvk commented Jul 16, 2019

Awesome, Thanks! I just migrated my project to Core 3 and everything seems alright so far.

@josephwambura
Copy link

Got error

C:\Program Files\dotnet\sdk\3.0.100-preview7-012821\Microsoft.Common.CurrentVersion.targets(3056,5): error MSB4216: Could not run the "GenerateResource" task because MSBuild could not create or connect to a task host with runtime "CLR4" and architecture "x86". Please ensure that (1) the requested runtime and/or architecture are available on the machine, and (2) that the required executable "C:\Program Files\dotnet\sdk\3.0.100-preview7-012821\MSBuild.exe" exists and can be run. [C:\Users\User\source\repos\MaterialDesignInXamlToolkit\MainDemo.Wpf\MaterialDesignDemo.csproj]
C:\Program Files\dotnet\sdk\3.0.100-preview7-012821\Microsoft.Common.CurrentVersion.targets(3056,5): error MSB4216: Could not run the "GenerateResource" task because MSBuild could not create or connect to a task host with runtime "CLR4" and architecture "x86". Please ensure that (1) the requested runtime and/or architecture are available on the machine, and (2) that the required executable "C:\Program Files\dotnet\sdk\3.0.100-preview7-012821\MSBuild.exe" exists and can be run. [C:\Users\User\source\repos\MaterialDesignInXamlToolkit\MahMaterialDragablzMashUp\MahAppsDragablzDemo.csproj]
18 Warning(s)
2 Error(s)

@josephwambura
Copy link

For UWP:

C:\Users\User\source\repos\MaterialDesignInXamlToolkit\MaterialDesignThemes.Uwp\MaterialDesignThemes.Uwp.csproj(237,3): error MSB4019: The imported project "C:\Program Files\dotnet\sdk\3.0.100-preview7-012821\Microsoft\WindowsXaml\v16.0\Microsoft.Windows.UI.Xaml.CSharp.targets" was not found. Confirm that the path in the declaration is correct, and that the file exists on disk.
C:\Users\User\source\repos\MaterialDesignInXamlToolkit\MainDemo.Uwp\MainDemo.Uwp.csproj(142,3): error MSB4019: The imported project "C:\Program Files\dotnet\sdk\3.0.100-preview7-012821\Microsoft\WindowsXaml\v16.0\Microsoft.Windows.UI.Xaml.CSharp.targets" was not found. Confirm that the path in the declaration is correct, and that the file exists on disk.
3 Warning(s)
2 Error(s)

@jespersh
Copy link
Contributor

jespersh commented Aug 3, 2019

@dansef what commands are you building with?

@Keboo Keboo added this to the 3.0.0 milestone Aug 12, 2019
@Keboo
Copy link
Member Author

Keboo commented Aug 12, 2019

Closing as the work for this has been done. For those wishing to try this out there are a few things to know.

  1. This is only available with the 3.0.0 preview NuGet packages
  2. MahApps is not currently supported with .NET Core 3.0, only the MaterialDesignThemes and MaterialDesignColors NuGet packages are expected to work. MahApps support will be forthcoming.

@Keboo Keboo closed this as completed Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants