Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MahApps Dragablz Demo Needs a DataGrid #1314

Open
Tide opened this issue Jul 9, 2019 · 6 comments
Open

MahApps Dragablz Demo Needs a DataGrid #1314

Tide opened this issue Jul 9, 2019 · 6 comments
Labels
demo app Items that relate to the demo application good first issue Items are good for new contributors. Hacktoberfest Items are good for new contributors during hacktoberfest. https://hacktoberfest.digitalocean.com/ mdix.mahapps Item relates to the MaterialDesignThemes.MahApps project up-for-grabs

Comments

@Tide
Copy link
Contributor

Tide commented Jul 9, 2019

The MahApps Dragablz demo needs a DataGrid added in order test all the MahApps brushes.
@Keboo Keboo added good first issue Items are good for new contributors. mdix.mahapps Item relates to the MaterialDesignThemes.MahApps project up-for-grabs labels Jul 9, 2019
@Mrxx99
Copy link
Contributor

Mrxx99 commented Jul 20, 2019

I am working on this. Just wondering if there should be anything special for that DataGrid. Currently I have a Checkbox-, Text-, Combobox and NumericUpDownColumn. But the Checkbox and ComboBox look like WPF default. Should I put the DataGrid resource dictionary as resource into the page?

@Keboo
Copy link
Member

Keboo commented Jul 25, 2019

@Mrxx99 sorry for the delay. That list of items look sufficient, even just simple text columns would probably exercise most of the MahApps brushes.

I am not sure about needing to include the resource dictionary. Can you open a PR and I can take a look.

@Mrxx99 Mrxx99 mentioned this issue Aug 3, 2019
Merged
@Keboo Keboo added demo app Items that relate to the demo application Hacktoberfest Items are good for new contributors during hacktoberfest. https://hacktoberfest.digitalocean.com/ labels Sep 23, 2019
@Keboo
Copy link
Member

Keboo commented Sep 23, 2019

@Mrxx99 are you still working on this?

@Mrxx99
Copy link
Contributor

Mrxx99 commented Sep 23, 2019

I opened the PR (#1348), but it had this theming issues. I didn't work any further on it yet, because you wanted to take a look at it

@Keboo
Copy link
Member

Keboo commented Sep 23, 2019

@Mrxx99 o sorry, it was late and I missed the PR link above. Thanks!

@Keboo Keboo closed this as completed in eaaeab4 Sep 24, 2019
@Keboo Keboo reopened this Sep 24, 2019
@Keboo
Copy link
Member

Keboo commented Sep 24, 2019

Merged in the current work for the data grid. The control now exists in the demo app but there are some issues as outlined in #1348

@Mrxx99 Mrxx99 mentioned this issue Oct 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
demo app Items that relate to the demo application good first issue Items are good for new contributors. Hacktoberfest Items are good for new contributors during hacktoberfest. https://hacktoberfest.digitalocean.com/ mdix.mahapps Item relates to the MaterialDesignThemes.MahApps project up-for-grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Tide @Keboo @Mrxx99