Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor UI Bugs - Playlist, Logo, and player #318

Open
Spaghetto392 opened this issue May 19, 2024 · 7 comments
Open

Minor UI Bugs - Playlist, Logo, and player #318

Spaghetto392 opened this issue May 19, 2024 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@Spaghetto392
Copy link

Describe the bug
The following UI elements behave in sometimes odd ways:

  • Playlist delete button doesn't follow accent color.
  • When player is just barely above mobile phone resolution, the Materialious logo clips into the search bar.
  • Occasionally when a video first loads, it will show the "Live" player before quickly changing the to regular player style, if a user clicks play on the live player, the video will not play correctly and will stay on a still of the thumbnail before hiding all controls.
  • If a user refreshes a video, the "Live" player seems to have a random chance of being used instead of the regular one. This player seems to exhibit similar behavior to the above bug.
  • Hovering over a comment with multiple timestamps will automatically click the timestamp the mouse cursor is over.
  • When a page is refreshed there is a small chance that options such as ReturnYoutubeDislikes or DASH playback will become disabled.
  • There is also a small chance that on refreshing, the video playback bar will instead be the default accent color of Materialious instead of the user defined one.

Desktop (please complete the following information):

  • OS: NixOS
  • Browser Librewolf, Chromium
  • Version 1.1.0

Additional context
To prevent spam, I thought it appropriate to merge these bugs into a single issue, if you would rather I divide any out into separate issues, please let me know.

@WardPearce
Copy link
Collaborator

Playlist delete button doesn't follow accent color.

This color is automatically picked based on your accent color.

Occasionally when a video first loads, it will show the "Live" player before quickly changing the to regular player style, if a user clicks play on the live player, the video will not play correctly and will stay on a still of the thumbnail before hiding all controls.

This is a issue with Vidstack & not Materialious to my understanding.

Hovering over a comment with multiple timestamps will automatically click the timestamp the mouse cursor is over.

This must be a bug with Materialious and how we handle comment timestamp parsing.

When a page is refreshed there is a small chance that options such as ReturnYoutubeDislikes or DASH playback will become disabled.

Never experienced this, how often does this occur?

@WardPearce WardPearce self-assigned this May 19, 2024
@WardPearce WardPearce added the bug Something isn't working label May 19, 2024
@Spaghetto392
Copy link
Author

Spaghetto392 commented May 19, 2024

This color is automatically picked based on your accent color.

After some testing with more colors, it does seem to be based off of the color picked but, it still retains a slightly different tint to everything else, is this intentional?

This is a issue with Vidstack & not Materialious to my understanding.

Interesting, if an issue isn't there already, I'll consider putting in my own.

Never experienced this, how often does this occur?

This seems to occur fairly infrequently, but usually coincides with the player accent color bug, which itself seems uncommon, I've gotten it to trigger by refreshing a video repeatedly.

EDIT: Markdown formatting.

@Spaghetto392
Copy link
Author

Spaghetto392 commented May 19, 2024

Another minor bug to report: The Unsubscribe button clips over the like counter when the window is narrow enough.
Screenshot_20240518_212600

(Above screenshot also showcases ReturnYoutubeDislikes disabling itself.)

@WardPearce
Copy link
Collaborator

This color is automatically picked based on your accent color.

After some testing with more colors, it does seem to be based off of the color picked but, it still retains a slightly different tint to everything else, is this intentional?

This is a issue with Vidstack & not Materialious to my understanding.

Interesting, if an issue isn't there already, I'll consider putting in my own.

Never experienced this, how often does this occur?

This seems to occur fairly infrequently, but usually coincides with the player accent color bug, which itself seems uncommon, I've gotten it to trigger by refreshing a video repeatedly.

EDIT: Markdown formatting.

Yes the colors is intentional by BeerCSS yes.

The player live issue always shows if a dash source is passed in Vidstack even if its set a not being a live stream.

And finally the issue with refreshing video page breaking things might be due to Vidstack erroring

@SleepyScribe
Copy link

Wanted to add this here, as it's also a UI bug, but for android. I figured it would be better to tack it on here, rather than making a new issue.

The area around my camera that is usually the status bar is a light grey in landscape and pretty distracting. I'm not sure if the issue is isolated to my phone or not.

Screenshot_20240519-094334.png

Phone: Pixel 7 Pro (non root)
Android Version: 14
App Version: 1.1.0

Suggested Fix: Is it possible to make the bar black instead?

@WardPearce
Copy link
Collaborator

Wanted to add this here, as it's also a UI bug, but for android. I figured it would be better to tack it on here, rather than making a new issue.

The area around my camera that is usually the status bar is a light grey in landscape and pretty distracting. I'm not sure if the issue is isolated to my phone or not.

Screenshot_20240519-094334.png

Phone: Pixel 7 Pro (non root) Android Version: 14 App Version: 1.1.0

Suggested Fix: Is it possible to make the bar black instead?

Yea interesting, same issue here. I'll look into it

@Spaghetto392
Copy link
Author

One more minor issue I've found:
Screenshot_20240519_234705
Youtube channel icon is allowed to go behind sidebar if the window/display is narrow enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants