Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting standard_conforming_strings to on #10691

Merged

Conversation

andrioni
Copy link
Contributor

Similar to TIMEZONE and client_encoding, only setting it to the default
value is supported: changing it to any other value is currently not supported.

Motivation

  • This PR fixes a previously unreported bug: setting standard_conforming_strings to its present value, which is required for Looker to work.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR adds a release note for any user-facing behavior changes.

Similar to TIMEZONE and client_encoding, only setting it to the default
value is supported: changing it to any other value is currently not supported.

Work done for compatibility with Looker.
@andrioni andrioni added this to In Progress in SQL and Coordinator Feb 15, 2022
@andrioni andrioni mentioned this pull request Feb 15, 2022
4 tasks
@andrioni andrioni merged commit 04b5f7e into MaterializeInc:main Feb 15, 2022
SQL and Coordinator automation moved this from In Progress to Landed Feb 15, 2022
@andrioni andrioni deleted the andrioni/standard-conforming-strings branch February 15, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants