Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to support dbt-core v1.3.0 #15321

Closed
2 of 3 tasks
dataders opened this issue Oct 10, 2022 · 1 comment · Fixed by #15875
Closed
2 of 3 tasks

upgrade to support dbt-core v1.3.0 #15321

dataders opened this issue Oct 10, 2022 · 1 comment · Fixed by #15875
Assignees
Labels
T-dbt Theme: dbt adapter

Comments

@dataders
Copy link

dataders commented Oct 10, 2022

Background

The latest release cut for 1.3.0, dbt-core==1.3.0rc2 was published on October 3, 2022 (PyPI | Github). We are targeting releasing the official cut of 1.3.0 in time for the week of October 16 (in time for Coalesce conference).

We're trying to establish a following precedent w.r.t. minor versions:
Partner adapter maintainers release their adapter's minor version within four weeks of the initial RC being released. Given the delay on our side in notifying you, we'd like to set a target date of November 7 (four weeks from today) for maintainers to release their minor version

Timeframe Date (intended) Date (Actual) Event
D - 3 weeks Sep 21 Oct 10 dbt Labs informs maintainers of upcoming minor release
D - 2 weeks Sep 28 Sep 28 core 1.3 RC is released
Day D October 12 Oct 12 core 1.3 official is published
D + 2 weeks October 26 Nov 7 dbt-adapter 1.3 is published

How to upgrade

dbt-labs/dbt-core#6011 is an open discussion with more detailed information, and dbt-labs/dbt-core#6040 is for keeping track of the community's progress on releasing 1.3.0

Below is a checklist of work that would enable a successful 1.3.0 release of your adapter.

  • Python Models (if applicable). Note: Not Applicable (yet).
  • Incremental Materialization: cleanup and standardization. Note: Not Applicable.
  • More functional adapter tests to inherit
@morsapaes morsapaes added the T-dbt Theme: dbt adapter label Oct 28, 2022
@ahelium ahelium self-assigned this Nov 3, 2022
@ahelium ahelium mentioned this issue Nov 3, 2022
3 tasks
@morsapaes
Copy link
Contributor

@dataders, a question about test coverage: is there a recommendation around what tests must be included in each external adapter's test suite? Since dbt-materialize tests run in our main CI pipeline, we'd like to keep things slim, if things can be kept slim!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-dbt Theme: dbt adapter
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants