coord: Don't count subsources for resource limits #15958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkosh44
force-pushed
the
fix-source-count
branch
3 times, most recently
from
ea88e09
to
8fadca2
Compare
f650ffb excluded counting subsources when counting new sources to create. However, it still included subsources when counting how many sources already exist. This commit fixes that issue so that subsources are excluded from the count of existing sources.
jkosh44
force-pushed
the
fix-source-count
branch
from
8fadca2
to
f1c6c2a
Compare
maddyblue
approved these changes
Nov 8, 2022
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f650ffb excluded counting subsources when counting new sources to create. However, it still included subsources when counting how many sources already exist. This commit fixes that issue so that subsources are excluded from the count of existing sources.
Motivation
This PR fixes a previously unreported bug.
Checklist
This PR has adequate test coverage / QA involvement has been duly considered.
This PR evolves an existing
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way) and therefore is tagged with aT-protolabel.This PR includes the following user-facing behavior changes: