Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyze changes need to make all transforms recursion_safe #17914

Closed
Tracked by #17012
aalexandrov opened this issue Mar 2, 2023 · 2 comments
Closed
Tracked by #17012

Analyze changes need to make all transforms recursion_safe #17914

aalexandrov opened this issue Mar 2, 2023 · 2 comments
Assignees

Comments

@aalexandrov
Copy link
Contributor

aalexandrov commented Mar 2, 2023

Go over all impl Transform blocks and fill in the table in the design doc (#17820) with appropriate estimates and notes about the work that needs to be done in order to stabilize each transform.

I suspect that work will generally fall into two categories:

  1. Transform implementations that don't depend on information derived from a structures or change structures that are LocalId references should work out of the box.
  2. Transform implementations that don't fall into this category. Those require more in-depth analysis, but most probably a common pattern will emerge.
@aalexandrov
Copy link
Contributor Author

aalexandrov commented Mar 14, 2023

Initial analysis is done and reflected in the design doc.

Trivially recursion safe transformations are marked as such in #18124.

There are 16 remaining transforms of which 12 need code changes before they can be marked as recursion_safe and 4 seem like a relatively straight-forward changes. After a second pass I will write some thoughts about changes needed to the non-trivial transformations.

@aalexandrov aalexandrov self-assigned this Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant