Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sentry: panic: id does not exist: IdentifierMissing(User(4)) #19897

Closed
sentry-io bot opened this issue Jun 13, 2023 · 4 comments · Fixed by #20267
Closed

sentry: panic: id does not exist: IdentifierMissing(User(4)) #19897

sentry-io bot opened this issue Jun 13, 2023 · 4 comments · Fixed by #20267
Assignees
Labels
A-ADAPTER Topics related to the ADAPTER layer C-bug Category: something is broken

Comments

@sentry-io
Copy link

sentry-io bot commented Jun 13, 2023

Sentry Issue: DATABASE-BACKEND-2S8

panic: id does not exist: IdentifierMissing(User(4))
  File "panicking.rs", line 575, in rust_begin_unwind
  File "read_policy.rs", line 501, in mz_adapter::coord::Coordinator::update_read_hold
  File "timeline.rs", line 903, in mz_adapter::coord::Coordinator::advance_timelines::{closure#0}::{closure#0}
  File "timeline.rs", line 878, in mz_adapter::coord::Coordinator::advance_timelines::{closure#0}
  File "message_handler.rs", line 68, in mz_adapter::coord::Coordinator::handle_message::{closure#0}
...
(26 additional frame(s) were not displayed)
@def-
Copy link
Contributor

def- commented Jun 13, 2023

There was a similar issue once before: #11568

But this seems to come from new RBAC code: adbf847 @jkosh44 (mz_adapter::coord::Coordinator::update_read_hold(read_policy.rs:501))

Happened on Materialize user on staging.

Could it be that a user is deleted during a transaction?

@def- def- added the C-bug Category: something is broken label Jun 13, 2023
@jkosh44
Copy link
Contributor

jkosh44 commented Jun 13, 2023

This is likely unrelated to RBAC. The User(4) here is the GlobalId of some storage collection. The User indicates that it's a user created collection, like a table or source.

This is also likely not caused by adbf847. That commit just switched all calls to unwrap() with calls to expect().

This error is fairly concerning though, the Coordinator and the controller seem to disagree about a certain collection existing. The Coordinator might have some stale state somewhere.

This does look extremely similar to this issue: #19398 and might in fact be a duplicate.

@chaas chaas added the A-ADAPTER Topics related to the ADAPTER layer label Jun 26, 2023
@benesch
Copy link
Member

benesch commented Jun 29, 2023

I think this might be a duplicate of #19743, actually.

@jkosh44
Copy link
Contributor

jkosh44 commented Jul 5, 2023

Reassigning this to @mjibson since he has a PR that fixes this.

@jkosh44 jkosh44 assigned maddyblue and unassigned jkosh44 Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ADAPTER Topics related to the ADAPTER layer C-bug Category: something is broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants