blue/green: Update items in the transaction all at once #26361
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR slightly refactors the
RenameSchema
op to update the durable transaction with the new items all at once instead of callingtx.update_item(...)
for each item.update_item(...)
iterates through the entire catalog every time it's called so it can be quite slow.Creating two schemas with 100 views each, and then 500 views depending on the 100 views in a schema we exhibit the following performance.
main
This PR
Motivation
Greatly improves the speed of
ALTER SCHEMA ... SWAP WITH ...
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.ALTER SCHEMA ... SWAP WITH ...