Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to std lib IpAddr is_global() method once stabilized #26649

Open
rjobanp opened this issue Apr 15, 2024 · 0 comments
Open

Switch to std lib IpAddr is_global() method once stabilized #26649

rjobanp opened this issue Apr 15, 2024 · 0 comments
Labels
A-STORAGE Topics related to the Storage layer C-refactoring Category: replacing or reorganizing code

Comments

@rjobanp
Copy link
Contributor

rjobanp commented Apr 15, 2024

We'd like to use the std::net::IpAddr is_global method directly when it is stabilized, which is being tracked in this upstream issue: rust-lang/rust#27709

Our own less-comprehensive version of this method is introduced in #26186 in src/ore/src/netio/dns.rs
@rjobanp rjobanp added C-refactoring Category: replacing or reorganizing code A-STORAGE Topics related to the Storage layer labels Apr 15, 2024
@rjobanp rjobanp mentioned this issue Apr 15, 2024
Merged
5 tasks
@guswynn guswynn mentioned this issue Apr 15, 2024
Closed
@morsapaes morsapaes mentioned this issue Apr 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-STORAGE Topics related to the Storage layer C-refactoring Category: replacing or reorganizing code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rjobanp