Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: allow casting interval to mz_timestamp #26970

Merged
merged 1 commit into from
May 8, 2024

Conversation

maddyblue
Copy link
Contributor

@maddyblue maddyblue commented May 7, 2024

Intervals should also be castable to timestamps since they can be expressed as milliseconds. This is similar to the other casts, and will also be useful for upcoming temporal filter improvements.

Motivation

  • This PR adds a feature that has not yet been specified.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:
    • Allow interval types to be cast to mz_timestamp.

@maddyblue maddyblue requested a review from a team as a code owner May 7, 2024 21:31
@maddyblue maddyblue requested a review from a team May 7, 2024 21:31
@maddyblue maddyblue requested a review from morsapaes as a code owner May 7, 2024 21:31
@maddyblue maddyblue requested a review from ParkMyCar May 7, 2024 21:31
@maddyblue maddyblue merged commit 4e3f73d into MaterializeInc:main May 8, 2024
78 checks passed
@maddyblue maddyblue deleted the mztimestamp-interval branch May 8, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants