Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Join expression constant folding #7570

Open
frankmcsherry opened this issue Jul 27, 2021 · 1 comment
Open

Improve Join expression constant folding #7570

frankmcsherry opened this issue Jul 27, 2021 · 1 comment
Assignees
Labels
A-optimization Area: query optimization and transformation C-bug Category: something is broken D-good second issue Difficulty: Good for a newcomer who's warmed up
Projects
Milestone

Comments

@frankmcsherry
Copy link
Contributor

Our join expression constant folding bails out if it sees a candidate number of rows that exceeds a threshold. However, it does this testing as it goes, before it applies equality constraints. Applying the equality constraints as one goes could dramatically reduce the number of candidates, and generally make the process faster as well as less likely to fail out.

@frankmcsherry frankmcsherry added C-bug Category: something is broken A-optimization Area: query optimization and transformation labels Jul 27, 2021
@uce uce added the D-good second issue Difficulty: Good for a newcomer who's warmed up label Jul 28, 2021
@uce uce added this to Icebox in Compute Jul 28, 2021
@uce uce added this to the Later milestone Jul 28, 2021
@aalexandrov aalexandrov self-assigned this Oct 21, 2021
@aalexandrov
Copy link
Contributor

I will pick this up next. If I read this correctly the right entry point for changing is this TODO comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-optimization Area: query optimization and transformation C-bug Category: something is broken D-good second issue Difficulty: Good for a newcomer who's warmed up
Projects
No open projects
Compute
Icebox
Development

No branches or pull requests

3 participants