Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HIR ⇒ QGM ⇒ MIR support for Reduce #9132

Closed
Tracked by #8073
aalexandrov opened this issue Nov 17, 2021 · 0 comments · Fixed by #9715
Closed
Tracked by #8073

HIR ⇒ QGM ⇒ MIR support for Reduce #9132

aalexandrov opened this issue Nov 17, 2021 · 0 comments · Fixed by #9715
Labels
A-optimization Area: query optimization and transformation

Comments

@aalexandrov
Copy link
Contributor

aalexandrov commented Nov 17, 2021 •
edited

  • Reduce will be translated to a single Grouping box.
  • In HIR, AggregateExpr is not a variant of ScalarExpr.
  • In QGM, aggregate expressions will be variant of ScalarExpr for the sake of putting this in the projection list of the Grouping box.
  • See the examples in the design doc for GROUP BY, GROUP BY + HAVING, and GROUP BY + DISTINCT.
  • The projection of the Grouping box should contain only
    • column references
    • aggregate expressions
@aalexandrov aalexandrov mentioned this issue Nov 17, 2021
Open
40 tasks
@aalexandrov aalexandrov added the A-optimization Area: query optimization and transformation label Nov 17, 2021
@aalexandrov aalexandrov added this to Needs Triage in Compute via automation Nov 17, 2021
@aalexandrov aalexandrov moved this from Needs Triage to Icebox in Compute Nov 17, 2021
@aalexandrov aalexandrov added needs-details Needs more details before work proceeds needs-discussion Requires discussion before work proceeds labels Nov 17, 2021
@aalexandrov aalexandrov removed this from Icebox in Compute Nov 17, 2021
@aalexandrov aalexandrov removed needs-details Needs more details before work proceeds needs-discussion Requires discussion before work proceeds labels Nov 18, 2021
@asenac asenac mentioned this issue Dec 21, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-optimization Area: query optimization and transformation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

qgm: support for Distinct and Reduce asenac/materialize
1 participant
@aalexandrov