Clarify page number for pagination

[merkys]

The changes:

1. Using page_number throughout the document (was page_page in one occurrence);
2. Making page_number explicitly 1-based.

Fixes #186

[CasperWA]

All fine for me - thanks @merkys.

Only a single comment, since I am unsure of all the different pagination setups. I am guessing that for the "page-based" pagination, page "size" is a specific thing?
Is it possible to add a reference to pagination definitions somewhere on www? Or is it considered bad practice?

[merkys]

Only a single comment, since I am unsure of all the different pagination setups. I am guessing that for the "page-based" pagination, page "size" is a specific thing?

Here "size" stands for the number of items on the page, fixed that in 837e83e.

Is it possible to add a reference to pagination definitions somewhere on www? Or is it considered bad practice?

I am not aware of any RFC or like document describing the pagination strategies. These seem straightforward (IMO), but I fully understand the need for the reference here.

[CasperWA]

Here "size" stands for the number of items on the page, fixed that in 837e83e.

Sure - but doesn't it always? I.e., shouldn't this explaining parenthesis be placed earlier?

Is it possible to add a reference to pagination definitions somewhere on www? Or is it considered bad practice?

I am not aware of any RFC or like document describing the pagination strategies. These seem straightforward (IMO), but I fully understand the need for the reference here.

Fair enough - it was also only if we knew of something, since it seemed to me the different kinds of pagination here were listed as if obvious and well-defined at another source.

[merkys]

Sure - but doesn't it always? I.e., shouldn't this explaining parenthesis be placed earlier?

It should, and it seems that it is explained earlier. I suppose we can remove it. It seems @dwinston has touched this text recently. @dwinston maybe you remember why we have this additional clarification of page_limit?

Fair enough - it was also only if we knew of something, since it seemed to me the different kinds of pagination here were listed as if obvious and well-defined at another source.

Again, maybe @dwinston knows a suitable reference?

[rartino]

I agree with @CasperWA that the clarification of page_limit is superfluous here. The use of it to set the sizes of the pages that are paginated should be obvious given its use in all pagination modes, and the general description just above.

[CasperWA]

Perfect, thanks @merkys!

[rartino]

All good.

[merkys]

Thanks for the reviews!