Apply suggestions from code review

Co-authored-by: Matthew Evans <7916000+ml-evs@users.noreply.github.com>
Materials-Consortia · May 9, 2022 · 8a06903 · 8a06903
1 parent 1d0356e
commit 8a06903
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/tests/server/conftest.py b/tests/server/conftest.py
@@ -117,7 +117,7 @@ def inner(
         server: Union[str, OptimadeTestClient] = "regular",
     ):
         response = get_good_response(request, server)
-        if type(response["data"]) == dict:
+        if isinstance(response["data"], dict):
             response_ids = [response["data"]["id"]]
         else:
             response_ids = [struct["id"] for struct in response["data"]]

diff --git a/tests/server/routers/test_structures.py b/tests/server/routers/test_structures.py
@@ -69,7 +69,7 @@ def test_structures_endpoint_data(self):
         assert "_exmpl_chemsys" in self.json_response["data"]["attributes"]
 
 
-def TestCheckResponseSingleStructure(check_response):
+def test_check_response_single_structure(check_response):
     """Tests whether check_response also handles single endpoint queries correctly."""
 
     test_id = "mpf_1"