Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastAPI should not be a core dependency #1198

Closed
ml-evs opened this issue May 29, 2022 · 1 comment · Fixed by #1199
Closed

FastAPI should not be a core dependency #1198

ml-evs opened this issue May 29, 2022 · 1 comment · Fixed by #1199
Labels
blocked For issues/PRs that are blocked by required changes/clarifications to the specification. ergonomics Features that improve the usability of the package suggestions

Comments

@ml-evs
Copy link
Member

ml-evs commented May 29, 2022

Currently FastAPI is a core dependency as it is required to generate the OpenAPI schemas. We should relegate it to a server dependency only, so we also avoid having to pull starlette etc. which can have awkward conflicting versions for those just wanting to use the models from this package.

I don't necessarily want to rush this through, but I think it would be a good idea to remove in time for 0.18, even if it breaks some existing packages.

@ml-evs ml-evs added suggestions ergonomics Features that improve the usability of the package labels May 29, 2022
@ml-evs ml-evs added the blocked For issues/PRs that are blocked by required changes/clarifications to the specification. label May 29, 2022
@ml-evs
Copy link
Member Author

ml-evs commented May 29, 2022

As #1199 shows, there is some minor interaction between the schemas, validator, and the FastAPI exceptions class that should be untangled before dropping the dep. Ideally we could extract all of the validator code out of the server module to make this clearer.

Let's leave this until a future release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked For issues/PRs that are blocked by required changes/clarifications to the specification. ergonomics Features that improve the usability of the package suggestions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant