Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demote FastAPI to a server dep only #1199

Merged
merged 2 commits into from Nov 24, 2022
Merged

Demote FastAPI to a server dep only #1199

merged 2 commits into from Nov 24, 2022

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented May 29, 2022

Closes #1198

@ml-evs ml-evs added the ergonomics Features that improve the usability of the package label May 29, 2022
@ml-evs ml-evs mentioned this pull request May 29, 2022
Closed
@ml-evs ml-evs marked this pull request as draft May 29, 2022 15:53
JPBergsma
JPBergsma previously approved these changes May 29, 2022
View reviewed changes
Copy link
Contributor

@JPBergsma JPBergsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code seems to do what the description says so this PR seems good to me.

@codecov
Copy link

codecov bot commented May 29, 2022 •
edited

Codecov Report

Merging #1199 (fe32aa4) into master (cd1dba6) will decrease coverage by 0.03%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #1199      +/-   ##
==========================================
- Coverage   91.46%   91.42%   -0.04%     
==========================================
  Files          72       72              
  Lines        4369     4372       +3     
==========================================
+ Hits         3996     3997       +1     
- Misses        373      375       +2
Flag Coverage Δ
project 91.42% <66.66%> (-0.04%) ⬇️
validator 91.48% <66.66%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade/server/schemas.py 94.44% <66.66%> (-5.56%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ml-evs
Copy link
Member Author

ml-evs commented May 29, 2022

The code seems to do what the description says so this PR seems good to me.

Holding this back for these reasons: #1198 (comment)

@ml-evs ml-evs added the on-hold For PRs/issues that are on-hold for an unspecified time label Sep 30, 2022
@ml-evs ml-evs force-pushed the ml-evs/demote_fastapi branch 3 times, most recently from c19926a to 63cef38 Compare November 24, 2022 14:03
@ml-evs ml-evs marked this pull request as ready for review November 24, 2022 15:24
@ml-evs ml-evs removed the on-hold For PRs/issues that are on-hold for an unspecified time label Nov 24, 2022
@ml-evs ml-evs mentioned this pull request Nov 24, 2022
Closed
3 tasks
JPBergsma
JPBergsma approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@JPBergsma JPBergsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ml-evs ml-evs merged commit 62b83fb into master Nov 24, 2022
@ml-evs ml-evs deleted the ml-evs/demote_fastapi branch November 24, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JPBergsma JPBergsma JPBergsma approved these changes

@CasperWA CasperWA Awaiting requested review from CasperWA CasperWA is a code owner

Assignees
No one assigned
Labels
ergonomics Features that improve the usability of the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FastAPI should not be a core dependency
2 participants
@ml-evs @JPBergsma