Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deserialization regressions: cannot resolve child databases in client #1843

Closed
ml-evs opened this issue Oct 30, 2023 · 0 comments · Fixed by #1844
Closed

Deserialization regressions: cannot resolve child databases in client #1843

ml-evs opened this issue Oct 30, 2023 · 0 comments · Fixed by #1844
Assignees
Labels
bug Something isn't working client Issues/PRs relating to the OPTIMADE client.

Comments

@ml-evs
Copy link
Member

ml-evs commented Oct 30, 2023

In "v1", the client can no longer resolve child databases, since when deserializing a LinksResponse, the LinkType enum is not present in the final model so a filter that checks link["attributes"]["link_type"] == LinkType.CHILD does not trigger.

I'm slightly worried that this opens us up to many more occurrences of this, so I would say this is a blocking issue. Our tests did not run into it as we do test the client on "live" provider data (maybe we should -- the test could just be whether there are ANY accessible OPTIMADE APIs out there, if this test fails for non-code reasons then we can probably roll up this package anyway 🙃)

@ml-evs ml-evs added bug Something isn't working client Issues/PRs relating to the OPTIMADE client. labels Oct 30, 2023
@ml-evs ml-evs self-assigned this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client Issues/PRs relating to the OPTIMADE client.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant