Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make client provider scraper more robust and add --version #1848

Merged
merged 2 commits into from Nov 5, 2023

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Nov 5, 2023

As above.

Prevents the client from breaking in untestable ways with future pydantic updates by explicitly deserializing links responses as links (related #1843).

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Merging #1848 (08128c0) into master (861ff08) will decrease coverage by 0.20%.
The diff coverage is 46.93%.

@@            Coverage Diff             @@
##           master    #1848      +/-   ##
==========================================
- Coverage   90.72%   90.53%   -0.20%     
==========================================
  Files          75       75              
  Lines        4605     4627      +22     
==========================================
+ Hits         4178     4189      +11     
- Misses        427      438      +11     
Flag Coverage Δ
project 90.53% <46.93%> (-0.20%) ⬇️
validator 89.99% <46.93%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
optimade/client/cli.py 86.36% <100.00%> (+0.42%) ⬆️
optimade/client/client.py 87.18% <91.66%> (+0.16%) ⬆️
optimade/utils.py 55.68% <28.57%> (-5.43%) ⬇️

@ml-evs ml-evs merged commit 2970d9a into master Nov 5, 2023
10 of 11 checks passed
@ml-evs ml-evs deleted the ml-evs/client-tweaks branch November 5, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant