Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing timeout for requests.get in get_providers #1954

Closed
ml-evs opened this issue Jan 30, 2024 · 0 comments · Fixed by #1955
Closed

Missing timeout for requests.get in get_providers #1954

ml-evs opened this issue Jan 30, 2024 · 0 comments · Fixed by #1955
Labels
bug Something isn't working

Comments

@ml-evs
Copy link
Member

ml-evs commented Jan 30, 2024 •
edited

This can cause semi-infinite hangs if the providers list is not accessible (e.g., due to a firewall).

Stumbled across this in a very roundabout way (https://matsci.org/t/current-nomad-images-seems-to-be-incomplete/53289), but this is 100% something we need to fix in 1.x and 0.25.x to avoid hard to debug issues like this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add requests timeout when getting providers list Materials-Consortia/optimade-python-tools
1 participant
@ml-evs