Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requests timeout when getting providers list #1955

Merged
merged 1 commit into from Jan 30, 2024

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Jan 30, 2024

Closes #1954, but will also need to be backported.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (404a48f) 90.79% compared to head (5d0fbe8) 90.75%.
Report is 7 commits behind head on master.

Files Patch % Lines
optimade/client/client.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1955      +/-   ##
==========================================
- Coverage   90.79%   90.75%   -0.05%     
==========================================
  Files          75       75              
  Lines        4728     4729       +1     
==========================================
- Hits         4293     4292       -1     
- Misses        435      437       +2     
Flag Coverage Δ
project 90.75% <50.00%> (-0.05%) ⬇️
validator 90.67% <50.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ml-evs ml-evs merged commit fe4995d into master Jan 30, 2024
11 of 12 checks passed
@ml-evs ml-evs deleted the ml-evs/fix-requests-timeout branch January 30, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing timeout for requests.get in get_providers
1 participant