Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CI linting more useful #269

Closed
ml-evs opened this issue May 6, 2020 · 2 comments · Fixed by #300
Closed

Make CI linting more useful #269

ml-evs opened this issue May 6, 2020 · 2 comments · Fixed by #300
Assignees
Labels
CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action) priority/low Issue or PR with a consensus of low priority
Projects

Comments

@ml-evs
Copy link
Member

ml-evs commented May 6, 2020

At some point when we switched over to GH actions, we started ignoring flake8 warnings, so they've been mounting up...

I would be in favor of leaving line length warnings muted as they will be handled by black, but there's quite a few others warning types that might need #noqa'ing in the code.

I also note that our "dev_requirements" currently contains pylint and not flake8, so we should either switch this round, move to pylint only, or start using both!

@ml-evs ml-evs added the CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action) label May 6, 2020
@CasperWA
Copy link
Member

CasperWA commented May 6, 2020

What's the advantage of using both? (Other than having two services yelling at you at once..)

@ml-evs
Copy link
Member Author

ml-evs commented May 6, 2020

AFAIK pylint has more checks for bad code smell, e.g. max function complexity and can be stricter with allowed variable names, but I haven't used it much.

I noticed that we have quite a few modules with pylint directives in them already, so presumably at some point the idea was to use pylint!

@ml-evs ml-evs added the priority/low Issue or PR with a consensus of low priority label Jun 5, 2020
@ml-evs ml-evs changed the title CI linting could be more useful Make CI linting more useful Jun 5, 2020
@CasperWA CasperWA added this to To do in CECAM 2020 via automation Jun 5, 2020
CECAM 2020 automation moved this from To do to Done Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action) priority/low Issue or PR with a consensus of low priority
Projects
CECAM 2020
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants