Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CI failures for linting #300

Merged
merged 3 commits into from Jun 10, 2020
Merged

Enable CI failures for linting #300

merged 3 commits into from Jun 10, 2020

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Jun 10, 2020

This PR updates the setup.cfg with some flake8 ignores: line length (which is handled by black) and module imports being at the top of a file.

Getting this to pass flake8 required a few tweaks: adding some noqa's and deleting some unused lines.

Closes #269.

@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #300 into master will decrease coverage by 0.02%.
The diff coverage is 80.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #300      +/-   ##
==========================================
- Coverage   90.05%   90.03%   -0.03%     
==========================================
  Files          54       54              
  Lines        2273     2268       -5     
==========================================
- Hits         2047     2042       -5     
  Misses        226      226              
Flag Coverage Δ
#unittests 90.03% <80.64%> (-0.03%) ⬇️
Impacted Files Coverage Δ
optimade/adapters/references/__init__.py 100.00% <ø> (ø)
optimade/adapters/structures/cif.py 100.00% <ø> (ø)
optimade/adapters/structures/pymatgen.py 100.00% <ø> (ø)
optimade/filtertransformers/django.py 91.07% <ø> (-0.31%) ⬇️
optimade/models/optimade_json.py 90.90% <0.00%> (ø)
optimade/models/references.py 97.61% <0.00%> (ø)
optimade/validator/validator.py 74.03% <0.00%> (ø)
optimade/filtertransformers/elasticsearch.py 87.74% <85.71%> (ø)
optimade/adapters/__init__.py 100.00% <100.00%> (ø)
optimade/models/__init__.py 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb50f92...3763146. Read the comment docs.

@ml-evs ml-evs requested a review from CasperWA June 10, 2020 20:13
Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So smooth, so clean, so awesome - thanks @ml-evs! :)

@ml-evs ml-evs merged commit 3c8c47f into master Jun 10, 2020
@CasperWA CasperWA deleted the ml-evs/update_ci branch June 10, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make CI linting more useful
2 participants