Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate bad version URLs responding with 553 Version Not Supported #427

Closed
ml-evs opened this issue Jul 22, 2020 · 0 comments · Fixed by #417
Closed

Validate bad version URLs responding with 553 Version Not Supported #427

ml-evs opened this issue Jul 22, 2020 · 0 comments · Fixed by #417
Assignees
@ml-evs
Labels
priority/medium Issue or PR with a consensus of medium priority validator Related to the OPTIMADE validator

Comments

@ml-evs
Copy link
Member

ml-evs commented Jul 22, 2020

Once #420 is merged, a check for the custom 553 Version Not Supported response should be added to the validator.
@ml-evs ml-evs added priority/medium Issue or PR with a consensus of medium priority validator Related to the OPTIMADE validator labels Jul 22, 2020
@ml-evs ml-evs self-assigned this Jul 22, 2020
@ml-evs ml-evs changed the title Validate incorrect version response Validate bad version URLs responding with 553 Version Not Supported Jul 22, 2020
@ml-evs ml-evs mentioned this issue Sep 3, 2020
Merged
10 tasks
@CasperWA CasperWA linked a pull request Sep 3, 2020 that will close this issue
Validator overhaul #417
Merged
10 tasks
ml-evs added a commit that referenced this issue Sep 11, 2020
@ml-evs
Validate versions endpoint and add extra test on meta->data_returned
dfa65e2 
- Test bad version responds with 553 (closes #427)
- Add validation of versions endpoint (closes #491)
- Add test for matching data_available and data_returned (closes #402)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ml-evs ml-evs

Labels
priority/medium Issue or PR with a consensus of medium priority validator Related to the OPTIMADE validator
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validator overhaul
1 participant
@ml-evs