Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type is missing in response #43

Closed
ltalirz opened this issue Jun 14, 2019 · 4 comments
Closed

type is missing in response #43

ltalirz opened this issue Jun 14, 2019 · 4 comments

Comments

@ltalirz
Copy link
Member

ltalirz commented Jun 14, 2019

No description provided.

@ltalirz
Copy link
Member Author

ltalirz commented Jun 14, 2019

@tpurcell90 this is something small that might be easy to fix?
another thing they noticed was about fixing the example string for the filter query that apparently wasn't quite according to the spec

@tpurcell90
Copy link
Contributor

This should be easy to fix, but I don't see a response field in the local_openapi.json that does not have a ref or type. Can you tell me what line it is on?

@ml-evs
Copy link
Member

ml-evs commented Oct 25, 2019

I think this is to do with L124 (and corresponding lines for other endpoints).

@app.get(
"/info",
response_model=Union[InfoResponse, ErrorResponse],
response_model_skip_defaults=True,
tags=["Info"],
)

Setting response_model_skip_defaults to false includes type='info' and id='/' in the response for the info endpoint (it also includes links=null and meta=null).

@CasperWA
Copy link
Member

CasperWA commented Nov 4, 2019

Closed by PR #65.

@CasperWA CasperWA closed this as completed Nov 4, 2019
Road to optimade-python-tools 1.0 automation moved this from To do to Done Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants