Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator message for wrong version #493

Closed
CasperWA opened this issue Sep 11, 2020 · 3 comments · Fixed by #494
Closed

Validator message for wrong version #493

CasperWA opened this issue Sep 11, 2020 · 3 comments · Fixed by #494
Labels
priority/medium Issue or PR with a consensus of medium priority validator Related to the OPTIMADE validator

Comments

@CasperWA
Copy link
Member

Testing the validator on Materials Cloud's sample OPTIMADE database yields a bit of a cryptic error:

✖: https://dev-aiida-dev.materialscloud.org/optimade-sample/optimade/v123123 - _get_endpoint - failed with error
        ResponseError: Request to 'v123123' returned HTTP code 404.
        Error(s):
          HTTPException: Not Found (N/A)

I believe this has to do with the return code not being correct? But it's difficult to understand from the message here.

@CasperWA CasperWA added priority/medium Issue or PR with a consensus of medium priority validator Related to the OPTIMADE validator labels Sep 11, 2020
@ml-evs
Copy link
Member

ml-evs commented Sep 11, 2020

Is that with the maximum verbosity? It should give you more than that...

@CasperWA
Copy link
Member Author

Is that with the maximum verbosity? It should give you more than that...

It is not. It is just running it normally.
But maybe it should be with maximum verbosity for errors, if possible?

@CasperWA
Copy link
Member Author

This is the error message with maximum verbosity:
I ran this on my local instance instead, hence the changed URL.

✖: http://localhost:5000/v123123 - _get_endpoint - failed with error
        ResponseError: Request to 'v123123' returned HTTP code 404.
        Error(s):
          HTTPException: Not Found (N/A)
        Traceback (most recent call last):
          File "/home/cwa/venv/optimade/optimade-python-tools/optimade/validator/utils.py", line 208, in wrapper
            raise exc
          File "/home/cwa/venv/optimade/optimade-python-tools/optimade/validator/utils.py", line 198, in wrapper
            result, msg = test_fn(validator, *args, **kwargs)
          File "/home/cwa/venv/optimade/optimade-python-tools/optimade/validator/validator.py", line 1082, in _get_endpoint
            raise ResponseError(message)
        optimade.validator.utils.ResponseError: Request to 'v123123' returned HTTP code 404.
        Error(s):
          HTTPException: Not Found (N/A)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/medium Issue or PR with a consensus of medium priority validator Related to the OPTIMADE validator
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants