Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error message for bad version returning 553 #494

Merged
merged 1 commit into from Sep 11, 2020

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Sep 11, 2020

Closes #493

@CasperWA CasperWA self-requested a review September 11, 2020 19:46
@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #494 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #494   +/-   ##
=======================================
  Coverage   91.48%   91.48%           
=======================================
  Files          61       61           
  Lines        3065     3065           
=======================================
  Hits         2804     2804           
  Misses        261      261           
Flag Coverage Δ
#project 91.48% <0.00%> (ø)
#validator 63.29% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade/validator/validator.py 82.18% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d53ab89...18e7988. Read the comment docs.

Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, thanks @ml-evs !

@ml-evs ml-evs merged commit 06dd2be into master Sep 11, 2020
@CasperWA CasperWA deleted the ml-evs/improve_error_message branch September 15, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validator message for wrong version
2 participants