Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validator should allow implementations to return "501 Not Implemented" for unsupported filters #518

Closed
ml-evs opened this issue Sep 23, 2020 · 1 comment
Closed

Validator should allow implementations to return "501 Not Implemented" for unsupported filters #518

ml-evs opened this issue Sep 23, 2020 · 1 comment
Assignees
@ml-evs
Labels
validator Related to the OPTIMADE validator

Comments

@ml-evs
Copy link
Member

ml-evs commented Sep 23, 2020

This is the preferred mechanism in the specification to report that optional filter features that are not supported, so we should allow it in the validator.

Personally, I think some of the query support levels need to be updated in the specification. None of our reference implementation, mcloud (@CasperWA) nor COD (@merkys) support queries on elements ratios particularly well; I would (and probably will) suggest tweaking the specification so that several fields that "MUST" be queryable can be downgrade to "SHOULD" be queryable, with the caveat that they must return 501 if they are not queryable in a particular implementation.
@ml-evs ml-evs added the validator Related to the OPTIMADE validator label Sep 23, 2020
@ml-evs ml-evs self-assigned this Sep 23, 2020
@merkys
Copy link
Member

merkys commented Oct 2, 2020

Downgrading some of MUSTs to SHOULDs in specification has already been proposed: Materials-Consortia/OPTIMADE#319.

ml-evs added a commit that referenced this issue Oct 19, 2020
@ml-evs
Allow filters to return 501 Not Implemented in all cases (closes #518)
fbcfd4a
ml-evs added a commit that referenced this issue Oct 19, 2020
@ml-evs
Allow filters to return 501 Not Implemented in all cases (closes #518)
b5a073e
ml-evs added a commit that referenced this issue Oct 19, 2020
@ml-evs
Allow filters to return 501 Not Implemented in all cases (closes #518)
4ede5b2
ml-evs added a commit that referenced this issue Oct 27, 2020
@ml-evs
Allow filters to return 501 Not Implemented in all cases (closes #518)
7d34632
@ml-evs ml-evs closed this as completed in 8b1685a Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ml-evs ml-evs

Labels
validator Related to the OPTIMADE validator
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ml-evs @merkys