Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make structure "deformity" tests more robust #583

Closed
ml-evs opened this issue Nov 2, 2020 · 0 comments · Fixed by #584
Closed

Make structure "deformity" tests more robust #583

ml-evs opened this issue Nov 2, 2020 · 0 comments · Fixed by #584
Assignees
Labels
priority/low Issue or PR with a consensus of low priority tests Related to tests

Comments

@ml-evs
Copy link
Member

ml-evs commented Nov 2, 2020

Following the discussion in #582:


Annoyingly if I hadn't made the extra field vs field.name mistake, then our tests would have caught this.

One extra comment here, we could make the deformity tests more robust by adding the expected error message for all of them too, this would have caught it as the validation of Hill formula cases was failing because of being out of alphabetical order rather than Hill. This will be a bit laborious but I can raise an issue and try to find the time.

Originally posted by @ml-evs in #582 (comment)

@ml-evs ml-evs added priority/low Issue or PR with a consensus of low priority tests Related to tests labels Nov 2, 2020
@ml-evs ml-evs self-assigned this Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/low Issue or PR with a consensus of low priority tests Related to tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant