You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Annoyingly if I hadn't made the extra field vs field.name mistake, then our tests would have caught this.
One extra comment here, we could make the deformity tests more robust by adding the expected error message for all of them too, this would have caught it as the validation of Hill formula cases was failing because of being out of alphabetical order rather than Hill. This will be a bit laborious but I can raise an issue and try to find the time.
Following the discussion in #582:
One extra comment here, we could make the deformity tests more robust by adding the expected error message for all of them too, this would have caught it as the validation of Hill formula cases was failing because of being out of alphabetical order rather than Hill. This will be a bit laborious but I can raise an issue and try to find the time.
Originally posted by @ml-evs in #582 (comment)
The text was updated successfully, but these errors were encountered: