Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added better expected error messages to deformity tests #584

Merged
merged 1 commit into from Nov 3, 2020

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Nov 3, 2020

Closes #583

@ml-evs ml-evs added priority/low Issue or PR with a consensus of low priority tests Related to tests labels Nov 3, 2020
@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #584 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #584   +/-   ##
=======================================
  Coverage   91.77%   91.77%           
=======================================
  Files          62       62           
  Lines        3222     3222           
=======================================
  Hits         2957     2957           
  Misses        265      265           
Flag Coverage Δ
project 91.77% <ø> (ø)
validator 64.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ed1f46...3e923bf. Read the comment docs.

@ml-evs ml-evs requested a review from CasperWA November 3, 2020 11:43
Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work my robot friend 😅 (seems like this was very much a robotic task to an extent...)

@ml-evs
Copy link
Member Author

ml-evs commented Nov 3, 2020

Great work my robot friend sweat_smile (seems like this was very much a robotic task to an extent...)

Story of my life...

@ml-evs ml-evs merged commit d48b7a8 into master Nov 3, 2020
@ml-evs ml-evs deleted the ml-evs/fix_#583 branch June 1, 2021 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/low Issue or PR with a consensus of low priority tests Related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make structure "deformity" tests more robust
2 participants