Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator should not rely on meta->data_available #677

Closed
ml-evs opened this issue Jan 18, 2021 · 0 comments · Fixed by #676
Closed

Validator should not rely on meta->data_available #677

ml-evs opened this issue Jan 18, 2021 · 0 comments · Fixed by #676
Labels
bug Something isn't working priority/high Issue or PR with a consensus of high priority validator Related to the OPTIMADE validator

Comments

@ml-evs
Copy link
Member

ml-evs commented Jan 18, 2021

A closely related issue is that even if the implementation returns meta->data_returned, one of the tests checks if an empty filter returns the same number for meta->data_returned and meta->data_available. This test appears to fail with a red checkmark if meta->data_available is not present. That field is on MAY level, so it is a quite major bug to fail implementations on missing that field.

Originally posted by @rartino in #675 (comment)

@ml-evs ml-evs added bug Something isn't working validator Related to the OPTIMADE validator priority/high Issue or PR with a consensus of high priority labels Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority/high Issue or PR with a consensus of high priority validator Related to the OPTIMADE validator
Projects
None yet
1 participant