Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.9 support invalid #728

Closed
CasperWA opened this issue Mar 3, 2021 · 5 comments
Closed

Python 3.9 support invalid #728

CasperWA opened this issue Mar 3, 2021 · 5 comments
Labels
bug Something isn't working python Pull requests that update Python code

Comments

@CasperWA
Copy link
Member

CasperWA commented Mar 3, 2021

In #660 we have seen that using pydantic < 1.7 fails the Python 3.9 CI job - which it should, because Python 3.9 support was not added until pydantic v1.7 (see changelog).

So official Python 3.9 support should be removed until we can support pydantic >= 1.7, which there is an open PR for: #715.

@CasperWA CasperWA added bug Something isn't working python Pull requests that update Python code labels Mar 3, 2021
@ml-evs
Copy link
Member

ml-evs commented Mar 3, 2021

Why hasn't this been failing for other PRs? I thought I'd just broken something by adding config values

@CasperWA
Copy link
Member Author

CasperWA commented Mar 3, 2021

No idea. But I don't want to waste time figuring it out. I'd rather just acknowledge that v1.6 of pydantic cannot be expected to support Python 3.9 and try instead to update our pydantic dependency.

@CasperWA
Copy link
Member Author

CasperWA commented Mar 3, 2021

An idea: You can try to install the #660 branch in a Python 3.9 environment, updating to the latest pydantic version (1.8) and run pytest?

@ml-evs
Copy link
Member

ml-evs commented Mar 4, 2021

An idea: You can try to install the #660 branch in a Python 3.9 environment, updating to the latest pydantic version (1.8) and run pytest?

I can confirm that everything passes

@CasperWA
Copy link
Member Author

CasperWA commented Mar 4, 2021

Closed by updating to pydantic~=1.8 in #731.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python Pull requests that update Python code
Projects
None yet
Development

No branches or pull requests

2 participants