Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 3.9 support until pydantic>=1.7 #729

Closed

Conversation

CasperWA
Copy link
Member

@CasperWA CasperWA commented Mar 3, 2021

As explained in #728, support for Python 3.9 in the optimade package is essentially invalid until we support pydantic>=1.7.

@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #729 (97c02a6) into master (c282454) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #729   +/-   ##
=======================================
  Coverage   92.81%   92.81%           
=======================================
  Files          67       67           
  Lines        3520     3520           
=======================================
  Hits         3267     3267           
  Misses        253      253           
Flag Coverage Δ
project 92.81% <ø> (ø)
validator 63.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c282454...97c02a6. Read the comment docs.

@CasperWA CasperWA mentioned this pull request Mar 3, 2021
@CasperWA
Copy link
Member Author

CasperWA commented Mar 3, 2021

Can be closed in favor of #731 if wanted.

@CasperWA CasperWA closed this in #731 Mar 4, 2021
@CasperWA CasperWA deleted the remove-python39-support branch March 4, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant