Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move aliasing code to base transformer #743

Closed
ml-evs opened this issue Mar 15, 2021 · 0 comments · Fixed by #797
Closed

Move aliasing code to base transformer #743

ml-evs opened this issue Mar 15, 2021 · 0 comments · Fixed by #797
Labels
priority/low Issue or PR with a consensus of low priority suggestions transformers Related to all filter transformers

Comments

@ml-evs
Copy link
Member

ml-evs commented Mar 15, 2021

Field aliasing should not be handled for each specific backend, this should be done by the BaseTransformer based on the attached ResoourceMapper.

@ml-evs ml-evs added priority/low Issue or PR with a consensus of low priority transformers Related to all filter transformers suggestions labels Mar 15, 2021
ml-evs added a commit that referenced this issue May 18, 2021
…oses #743)

- Add entry resource class attribute to mappers, use that to scrape attributes

- Use new BaseTransformer to handle aliasing in MongoTransformer

- Move definitions of ES quantities away from server and into mapper

- Improve MongoFilterTransformer tests by using OPTIMADE queries directly

- Add more ES FilterTransformer tests for KNOWN/UNKNOWN and fix weird dimension_types test

- Extract as much info from schemas to construct mappers

- Tweak and use retrieve_queryable_properties in mapper

- Provide clearer error message for ES relationship filtering

- Docstrings and annotations for transformers

- Make reversed_operator_map and quantity_type private
ml-evs added a commit that referenced this issue May 27, 2021
…oses #743)

- Add entry resource class attribute to mappers, use that to scrape attributes

- Use new BaseTransformer to handle aliasing in MongoTransformer

- Move definitions of ES quantities away from server and into mapper

- Improve MongoFilterTransformer tests by using OPTIMADE queries directly

- Add more ES FilterTransformer tests for KNOWN/UNKNOWN and fix weird dimension_types test

- Extract as much info from schemas to construct mappers

- Tweak and use retrieve_queryable_properties in mapper

- Provide clearer error message for ES relationship filtering

- Docstrings and annotations for transformers

- Make reversed_operator_map and quantity_type private
ml-evs added a commit that referenced this issue May 31, 2021
…oses #743)

- Add entry resource class attribute to mappers, use that to scrape attributes

- Use new BaseTransformer to handle aliasing in MongoTransformer

- Move definitions of ES quantities away from server and into mapper

- Improve MongoFilterTransformer tests by using OPTIMADE queries directly

- Add more ES FilterTransformer tests for KNOWN/UNKNOWN and fix weird dimension_types test

- Extract as much info from schemas to construct mappers

- Tweak and use retrieve_queryable_properties in mapper

- Provide clearer error message for ES relationship filtering

- Docstrings and annotations for transformers

- Make reversed_operator_map and quantity_type private
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/low Issue or PR with a consensus of low priority suggestions transformers Related to all filter transformers
Projects
None yet
1 participant