Use diff for checking PR body
#1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Success! The temporary job (see here) shows that the diff approach will indeed work. |
This reverts commit ad13800.
|
Note, I have manually force-pushed and reset |
Codecov Report
@@ Coverage Diff @@
## master #1000 +/- ##
=======================================
Coverage 92.91% 92.91%
=======================================
Files 67 67
Lines 3780 3780
=======================================
Hits 3512 3512
Misses 268 268
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Ooohhhh.... issue/pull number 1000 🤩 |
And what a way to do it... Who would've guessed it would be on fixing automated procedures ;) |
ml-evs
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #995
This tries to use
diffinstead to check whether the first 8 lines of the latest PR body text is equal to the first 8 lines of.github/utils/single_dependency_pr_body.txt.This test is the basis for whether the
dependabot_updatesbranch should be reset tomaster(when it has been utilized to update dependencies) ormastershould just be merged intodependabot_updates(when any other PR is merged intomaster).I've added a single commit here that will be reverted, but it implements a temporary CI test to check the new method.
It retrieves the PR body for the latest PR that should initiate resetting
dependabot_updates, and it also retrieves a PR body for another random PR that should initiate the merge.Then it uses the
diffapproach for both and finally uses it within anif-sentence as is intended.