Make NumPy requirement py version-specific #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to update `setup.py` as the current settings should ensure the correct version is installed for the respective Python version when installing through `pip install .` instead of installing the dependencies through the requirements files.
Codecov Report
@@ Coverage Diff @@
## master #1036 +/- ##
=======================================
Coverage 92.34% 92.34%
=======================================
Files 67 67
Lines 3790 3790
=======================================
Hits 3500 3500
Misses 290 290
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to update
setup.pyas the current settings should ensure thecorrect version is installed for the respective Python version when
installing through
pip install .instead of installing thedependencies through the requirements files.
Fixes #1035
Fixes #1037
The commit 426cccc has been cherry-picked and added to this branch,
fixing the issue with the failling Docs CI strict build.