Cancel CI PR jobs that are in progress with new changes, add skip_changelog label to overrides

[ml-evs]

As above. This PR will cancel workflows from running when new changes are pushed to a PR.

[codecov]

Codecov Report

Merging #1057 (86e6973) into master (b473382) will not change coverage.
The diff coverage is n/a.

❗ Current head 86e6973 differs from pull request most recent head 4da9bdd. Consider uploading reports for the commit 4da9bdd to get more accurate results

@@           Coverage Diff           @@
##           master    #1057   +/-   ##
=======================================
  Coverage   92.90%   92.90%           
=======================================
  Files          67       67           
  Lines        3790     3790           
=======================================
  Hits         3521     3521           
  Misses        269      269           

Flag	Coverage Δ
project	92.90% <ø> (ø)
validator	92.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
optimade/validator/utils.py	94.63% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b473382...4da9bdd. Read the comment docs.

[CasperWA]

This confuses me. You are now excluding all PRs with a CI label in the changelog and also changing the way CI workflows are run? It seems the PR should only be for the latter?

[ml-evs]

This confuses me. You are now excluding all PRs with a CI label in the changelog and also changing the way CI workflows are run? It seems the PR should only be for the latter?

Yes, I thought the CI changelog change is a minor one so added it alongside this CI tweak. Another option would be to add a special label "skip_changelog" that we can use to manually override the rule. Do you think CI changes should be in the changelog?

[CasperWA]

Yes, I thought the CI changelog change is a minor one so added it alongside this CI tweak. Another option would be to add a special label "skip_changelog" that we can use to manually override the rule. Do you think CI changes should be in the changelog?

A skip_changelog label sounds like the perfect solution for this.
While CI changes are not directly related to the package, I don't want to hide the work done to automate and implement good testing and more from the changelog. I think it's a big part of what makes the repository strong; solid CI/CD and should therefore be credited and included in the changelog.

[ml-evs]

Yes, I thought the CI changelog change is a minor one so added it alongside this CI tweak. Another option would be to add a special label "skip_changelog" that we can use to manually override the rule. Do you think CI changes should be in the changelog?

A skip_changelog label sounds like the perfect solution for this. While CI changes are not directly related to the package, I don't want to hide the work done to automate and implement good testing and more from the changelog. I think it's a big part of what makes the repository strong; solid CI/CD and should therefore be credited and included in the changelog.

Fair point, I guess we can push the quibbling to whether each individual PR should have a skip_changelog tag 🙃 I will do it for this one at least...

[CasperWA]

Yes, I thought the CI changelog change is a minor one so added it alongside this CI tweak. Another option would be to add a special label "skip_changelog" that we can use to manually override the rule. Do you think CI changes should be in the changelog?

A skip_changelog label sounds like the perfect solution for this. While CI changes are not directly related to the package, I don't want to hide the work done to automate and implement good testing and more from the changelog. I think it's a big part of what makes the repository strong; solid CI/CD and should therefore be credited and included in the changelog.

Fair point, I guess we can push the quibbling to whether each individual PR should have a skip_changelog tag 🙃 I will do it for this one at least...

Not sure that should be the case either. I like a chunky changelog 😅 Even if each line represents a few character changes in the code base... Depending on the characters changed the PR may be significant or not ;)

[ml-evs]

Not sure that should be the case either. I like a chunky changelog 😅 Even if each line represents a few character changes in the code base... Depending on the characters changed the PR may be significant or not ;)

Hmm, I guess this is an important point then. To me, our changelog is user-facing (where user could include anyone who depends on this library) and not developer facing. But I guess your issue with the "Update Dependency" entries was more the repetition (and lack of info)? I'm not overly fussed either way, if skip_changelog works for you then we can just merge this and use it sparingly (for cases where we mess up, for example 🙃)

[ml-evs]

(The cancel in progress thing works nicely though, should save us some build minutes across here and the dashboard builds)

[JPBergsma]

I did not see anything wrong with this PR.
I do not know much about GitHub actions, though, so a mistake could easily have slipped past me.

[ml-evs]

I think @CasperWA and I reached agreement on the labelling, so I will merge this now