Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added option to validate incoming URL query parameters #1122

Merged
merged 13 commits into from
Apr 30, 2022
Merged

Added option to validate incoming URL query parameters #1122

merged 13 commits into from
Apr 30, 2022

Commits on Apr 18, 2022

  1. Added a check to determine if query parameters are correct.

    @JPBergsma
    JPBergsma committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    bb5e65a View commit details
    Browse the repository at this point in the history

  2. Now I have also added the check for the single entry entry point.

    @JPBergsma
    JPBergsma committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    7934450 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2022

  1. Moved the check param function to query_params.py, added a flag to tu… 

    …rn the check on or off and the check now accumulates the warnings/errors.
    @JPBergsma
    JPBergsma committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    44b7955 View commit details
    Browse the repository at this point in the history

  2. Now only the parameters as determined by FAST API are transferred to … 

    …the check_params method, instead of the whole request.
    @JPBergsma
    JPBergsma committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    22cf3cf View commit details
    Browse the repository at this point in the history

  3. Added docstring and now any iterable is allowed as input.

    @JPBergsma
    JPBergsma committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    425d489 View commit details
    Browse the repository at this point in the history

  4. Added docstring and now any iterable is allowed as input.

    @JPBergsma
    JPBergsma committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    b732778 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2022

  1. Removed accidentaly added blanc line.

    @JPBergsma
    JPBergsma committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    641ac7b View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Matthew Evans <7916000+ml-evs@users.noreply.github.com>
    @JPBergsma @ml-evs
    JPBergsma and ml-evs committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    1bcff25 View commit details
    Browse the repository at this point in the history

  2. Processed suggestions ml-evs, made check_params an ABC class.

    @JPBergsma
    JPBergsma committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    5523405 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into JPBergsma_add_parameter_check

    @JPBergsma
    JPBergsma committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    b7022ac View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2022

  1. By using getattr we won't break compatability with preexisting config… 

    … files.
    @JPBergsma
    JPBergsma committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    9989f72 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Matthew Evans <7916000+ml-evs@users.noreply.github.com>
    @JPBergsma @ml-evs
    JPBergsma and ml-evs committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    7d80fab View commit details
    Browse the repository at this point in the history

  3. Letting Black do it's thing after accepting changes on Github.

    @JPBergsma
    JPBergsma committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    59933df View commit details
    Browse the repository at this point in the history