New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cases where comparison first and property first queries did not match #1134
Fix cases where comparison first and property first queries did not match #1134
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1134 +/- ##
==========================================
+ Coverage 92.33% 92.37% +0.03%
==========================================
Files 68 68
Lines 3849 3881 +32
==========================================
+ Hits 3554 3585 +31
- Misses 295 296 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test that fails without these proposed changes, and passes with them? I imagine you have implicitly done this by adding the extra reference test case, but it would be good to see it clearly.
I have added a few test for the MongoDB filter transformer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
…in optimade/filtertransformers/mongo.py so and are handled priperly for constant_first_comparisons.
30cab68
to
464f0b9
Compare
Rerouted 'constant_first_comparison' via 'property_first_comparison' in optimade/filtertransformers/mongo.py so $ne and $size are handled properly for constant_first_comparisons.
Closes #1133