Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub Actions for Heroku deployment #1165

Merged
merged 1 commit into from May 9, 2022
Merged

Use GitHub Actions for Heroku deployment #1165

merged 1 commit into from May 9, 2022

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented May 9, 2022

Due to ongoing security issues with Heroku, they have disabled the direct GitHub integration.

This PR uses GitHub actions to deploy to Heroku via the https://github.com/AkhileshNS/heroku-deploy Action (20k+ users, seems fine).

The required credentials have been added as GH actions secrets (using my Heroku account API key).

I tested this on my fork and it works fine, this will only run after it is merged to master so I will double-check afterwards.

We can then disable Heroku automated deployment, remove the config vars from Heroku, and upgrade the heroku stack to v20.

Closes #1158.

@ml-evs ml-evs marked this pull request as draft May 9, 2022 12:24
@ml-evs ml-evs closed this May 9, 2022
@ml-evs ml-evs reopened this May 9, 2022
@ml-evs ml-evs changed the title Test heroku deploy Use GitHub Actions for Heroku deployment May 9, 2022
@ml-evs ml-evs marked this pull request as ready for review May 9, 2022 14:26
@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #1165 (b687748) into master (255a402) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1165   +/-   ##
=======================================
  Coverage   92.32%   92.32%           
=======================================
  Files          68       68           
  Lines        3894     3894           
=======================================
  Hits         3595     3595           
  Misses        299      299           
Flag Coverage Δ
project 92.32% <ø> (ø)
validator 92.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 255a402...b687748. Read the comment docs.

@ml-evs
Copy link
Member Author

ml-evs commented May 9, 2022

Going to self-merge as this can only really be tested once its in!

@ml-evs ml-evs linked an issue May 9, 2022 that may be closed by this pull request
@ml-evs ml-evs enabled auto-merge (squash) May 9, 2022 14:39
@ml-evs ml-evs disabled auto-merge May 9, 2022 14:39
@ml-evs ml-evs merged commit deef887 into Materials-Consortia:master May 9, 2022
@ml-evs ml-evs deleted the ml-evs/deploy-heroku branch May 9, 2022 14:39
@ml-evs ml-evs restored the ml-evs/deploy-heroku branch May 9, 2022 14:41
@ml-evs
Copy link
Member Author

ml-evs commented May 9, 2022

Failed due to missing credentials, need to rerun from master.

@ml-evs ml-evs added deployment An app serves the OPTIMADE regular server CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action) labels May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action) deployment An app serves the OPTIMADE regular server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heroku not deploying
1 participant